Yes, teachers and nurses I think are much better off here financially. University lecturers may earn more too but in most academic fields, bar law, PhD/equivalent is required even at lecturer level (i.e. not senior lecturer) and you will be assessed annually on your international publications (minimum requirement usually 2 articles in international journals) - including the level of journal you manage to publish in. I know that in RSA many academics are often not required to publish at all. The only way for an academic to become a professor for example in NZ is by a high level of prestigious publication. A book or two may even be required. But I'm sure academics know this and have done their research in this regard.
Medical drs, lawyers (once they've done the bridging course), chartered accountants, accountants, engineers, anyone who was at a corporate CEO/director level, senior executives etc. will likely be worse off - financially. I can't vouch for tradies (plumbers, electricians, mechanics et al). It is however my suspicion that if they were employed in RSA (not successfully self-employed) then they may be financially better off too.
It is my understanding that many people (or enough anyway to justify the statements) arrive here on Permanent Residence Visas, granted them by the NZ government because they have the right skills and skills that are supposedly in demand in NZ. After arrival they discover that it can take as long as 6 - 8 months or even longer to secure a job. Therefore the conversion from Rand to NZ$ or vice versa is very much real and relevant to those people. As I've said: "limping along on your savings".
Fruit & veg can be very, very expensive (if you're paying in Rand) and meat and fish the same. That's why so many people start planting their own veg (if they can). Buy fresh produce at Fruit & Veg shops (NOT supermarkets) and meat at The Mad Butcher (only available in big towns/"cities"). Much like RSA, NZ also exports its best and the locals are left with the poorer quality.
And yes. As much as everything these days is made in China (included flipping MacIntosh computers for example!), NZ does unfortunately include a lot of cheap shite imports from China to stock their shelves with. Think general household goods. E.g. toilet brushes, toasters, kettles, hair dryers, plastic containers, etc. And clothing for sure.